| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: Trigonometric functions in degrees |
| Date: | 2015-11-30 13:40:59 |
| Message-ID: | CAB7nPqTQcRawkES1j2Om0Cjhgy_9VjDnk+JzGGUQf7WYsNpg+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 30, 2015 at 10:39 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Nov 30, 2015 at 10:36 PM, Michael Paquier wrote:
>> Instinctively, it seems to me that we had better return Nan for the
>> new asind and acosd when being out of range for OSX, Linux will
>> complain about an out-of-range error so the code is right in this
>> case.
>
> This is still mentioned upthread btw. And it does not seem to be a
> good idea to change this platform dependent behavior by throwing an
> error on the old functions, neither does it seem user-friendly to have
> inconsistent results for the XXX function and its XXXd equivalent.
At this stage, it seems wiser to me to mark this patch as "returned
with feedback". Other opinions of course are welcome.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shulgin, Oleksandr | 2015-11-30 13:41:02 | Re: Revisiting pg_stat_statements and IN() (Was: Re: pg_stat_statements fingerprinting logic and ArrayExpr) |
| Previous Message | Michael Paquier | 2015-11-30 13:39:58 | Re: Proposal: Trigonometric functions in degrees |