| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: improved DefElem list processing |
| Date: | 2016-08-22 14:25:09 |
| Message-ID: | CAB7nPqTNqY0G_oAcW9yepXd0ArvZgUaQd4XhHBqBD-qjdqMgOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 22, 2016 at 10:41 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> 1. This patch introduce location in DefElement node, and inject ParserState
> to SQL commands, where ParserState was not used. It allows to show the
> position of an error. This patch is not small, but almost changes are
> trivial.
>
> 2. There are no problems with patching, compiling, tests - all tests passed.
>
> 3. There is not any new functionality, so new tests and new documentation is
> not necessary.
>
> I'll mark this patch as ready for commiter.
Now that I look at those patches, +1 for both. Particularly the
redundant-option checks will remove a lot of boring code.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-08-22 14:28:37 | Re: improved DefElem list processing |
| Previous Message | Amit Kapila | 2016-08-22 14:04:24 | Re: dsm_unpin_segment |