| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Check interrupts during hot standby waits |
| Date: | 2017-01-27 02:24:16 |
| Message-ID: | CAB7nPqTHLpuv1B71xV3KznHQjSt3Bv3Y0vpoGif1ojuVhM787A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 27, 2017 at 4:06 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2017-01-26 19:00:34 +0000, Simon Riggs wrote:
>> Check interrupts during hot standby waits
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec
>>
>> Modified Files
>> --------------
>> src/backend/storage/ipc/standby.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> It seems that the actual fix here would be to replace the pg_usleep loop
> with a latch wait.... Then we also don't need to needlessly loop, and
> actually react promptly to signals.
For the record, a patch has been posted on the original thread:
https://www.postgresql.org/message-id/CAB7nPqRNcd+FR=8_Lyb65jBcRPX+59hXobi5G-wf4fxRak_6gw@mail.gmail.com
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-01-27 03:09:41 | pgsql: Use castNode() in a bunch of statement-list-related code. |
| Previous Message | Andres Freund | 2017-01-27 00:58:00 | pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-01-27 02:26:58 | Re: pg_hba_file_settings view patch |
| Previous Message | Michael Paquier | 2017-01-27 02:23:18 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |