Re: Support for REINDEX CONCURRENTLY

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Support for REINDEX CONCURRENTLY
Date: 2013-07-11 23:39:05
Message-ID: CAB7nPqTGa_my7yUYxJqeH_0eYPLRyrGiHXhKOKNLkmVLLWu6uQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 11, 2013 at 5:11 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> I am resending the patches after Fujii-san noticed a bug allowing to
> even drop valid toast indexes with the latest code... While looking at
> that, I found a couple of other bugs:
> - two bugs, now fixed, with the code path added in tablecmds.c to
> allow the manual drop of invalid toast indexes:
> -- Even a user having no permission on the parent toast table could
> drop an invalid toast index
> -- A lock on the parent toast relation was not taken as it is the case
> for all the indexes dropped with DROP INDEX
> - Trying to reindex concurrently a mapped catalog leads to an error.
> As they have no relfilenode, I think it makes sense to block reindex
> concurrently in this case, so I modified the core patch in this sense.
This patch status has been changed to returned with feedback.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chad Wagner 2013-07-12 00:46:57 Re: Preventing tuple-table leakage in plpgsql
Previous Message Tom Lane 2013-07-11 19:09:45 Re: mvcc catalo gsnapshots and TopTransactionContext