| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: TAP / recovery-test fs-level backups, psql enhancements etc |
| Date: | 2016-03-03 05:23:42 |
| Message-ID: | CAB7nPqTF7nyLSL-fZn+M32hK0AJ0piOnAJ49NSdr+i-5UVjpgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 3, 2016 at 2:20 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On the Perl 5.8.8 test env I've set up now, per
>
> http://www.postgresql.org/message-id/CAMsr+YGR6pU-gUyp-FT98XwXAsc9n6j-awZAqxvW_+P3RTC7cg@mail.gmail.com
>
> master currently fails with
>
> t/004_timeline_switch....."remove_tree" is not exported by the File::Path
> module
>
> remove_tree is only in File::Path 2.07 but Perl 5.8.8 has 1.08. No buildfarm
> member has complained, so clearly we don't actually test with the stated
> supported Perl version.
>
> The attached patch fixes it to use the legacy File::Path interface 'rmtree'
> so master runs on 588 again.
Crap. Thanks for spotting that, I was careless. You could still use
qw() and not use File::Path::rmtree, but that's a matter of taste.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2016-03-03 05:51:45 | Re: SP-GiST support for inet datatypes |
| Previous Message | Craig Ringer | 2016-03-03 05:20:17 | Re: TAP / recovery-test fs-level backups, psql enhancements etc |