Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}
Date: 2014-12-22 02:10:02
Message-ID: CAB7nPqTDkatemGY-ZvnhJEf41iK=HKLvuO5Zm9+k-Wrbxs7PGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 21, 2014 at 6:56 AM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Thu, Dec 18, 2014 at 9:31 AM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>>> So I think there needs to be some kind of logic to de-recognize the table
>>> alias "foo".
>>>
>>> Once I rewrote the query to use TARGET and EXCLUDED correctly, I've put this
>>> through an adaptation of my usual torture test, and it ran fine until
>>> wraparound shutdown. I'll poke at it more later.
>>
>> Oops. I agree with your diagnosis, and will circle around to fix that
>> bug in the next revision
>
> Attached patch fixes the bug. I'm not delighted about the idea of
> cutting off parent parse state (the parse state of the insert) within
> transformUpdateStmt() only once we've used the parent state to
> establish that this is a "speculative"/auxiliary update, but it's
> probably the path of least resistance here.
>
> When this is rolled into the next version, there will be a testcase.
Looking at this thread, the last version of this patch is available here:
http://www.postgresql.org/message-id/CAM3SWZRvkCKc=1Y6_Wn8mk97_Vi8+j-aX-RY-=msrJVU-Ec-qw@mail.gmail.com
And they do not apply correctly, so this patch needs a rebase.
Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-12-22 02:20:21 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}
Previous Message Jim Nasby 2014-12-22 02:04:56 Re: Parallel Seq Scan