| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in ExecModifyTable function and trigger issues for foreign tables |
| Date: | 2017-05-15 05:48:53 |
| Message-ID: | CAB7nPqTDH22V+9Otz3SH2n9_-skVhM8fOxVBCksgf5mbqN+rgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 15, 2017 at 2:04 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>> After your fix, now tupleid is invalid which is expected, but seems
>> like we need to do something more. As per the comments seems like it
>> is expected to get the oldtuple from planSlot. But I don't see any
>> code for handling that part.
>
> Maybe we should do something like attached patch.
As a deficiency, shouldn't this try as well to improve regression test
coverage for FDW triggers with inheritance trees? Those tests are in
postgres_fdw. You may find other issues on the way..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-05-15 06:02:54 | Re: Event triggers + table partitioning cause server crash in current master |
| Previous Message | Michael Paquier | 2017-05-15 05:35:20 | Re: Duplicate usage of tablespace location? |