Re: Support for REINDEX CONCURRENTLY

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Support for REINDEX CONCURRENTLY
Date: 2013-03-17 12:24:16
Message-ID: CAB7nPqTBBbUvqLptx2w=EkKE+YHi4TPK8x7r=2iZuZj3o+wgWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Please find attached the patches wanted:
- 20130317_reindexdb_concurrently.patch, adding an option -c/--concurrently
to reindexdb
Note that I added an error inside reindexdb for options "-s -c" as REINDEX
CONCURRENTLY does not support SYSTEM.
- 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump
not take a dump of invalid indexes. This patch can be backpatched to 9.0.

On Sun, Mar 17, 2013 at 3:31 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com>wrote:

> On 2013/03/17, at 0:35, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> > On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier
> > I found pg_dump dumps even the invalid index. But pg_dump should
> > ignore the invalid index?
> > This problem exists even without REINDEX CONCURRENTLY patch. So we might
> need to
> > implement the bugfix patch separately rather than including the bugfix
> > code in your patches.
> > Probably the backport would be required. Thought?
> Hum... Indeed, they shouldn't be included... Perhaps this is already known?
>
Note that there have been some recent discussions about that. This
*problem* also concerned pg_upgrade.
http://www.postgresql.org/message-id/20121207141236.GB4699@alvh.no-ip.org
--
Michael

Attachment Content-Type Size
20130317_reindexdb_concurrently.patch application/octet-stream 5.8 KB
20130317_dump_only_valid_index.patch application/octet-stream 484 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marti Raudsepp 2013-03-17 13:17:30 [PATCH] Version info mixes up host and target platform when cross-compiling
Previous Message Boszormenyi Zoltan 2013-03-17 08:00:50 Re: Strange Windows problem, lock_timeout test request