| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru> |
| Cc: | Piotr Stefaniak <email(at)piotr-stefaniak(dot)me>, "obartunov(at)gmail(dot)com" <obartunov(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)postgrespro(dot)ru>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: SQL/JSON in PostgreSQL |
| Date: | 2017-11-03 12:34:01 |
| Message-ID: | CAB7nPqTAR2wx1EbUc+YWwh_DzBsLswzvay7rvDqVvDoUWk0rWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 3, 2017 at 12:07 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> The patch sent previously does not directly apply on HEAD, and as far
> as I can see the last patch set published on
> https://www.postgresql.org/message-id/2361ae4a-66b1-c6c5-ea6a-84851a1c08b5@postgrespro.ru
> has rotten. Could you send a new patch set?
>
> About the patch set, I had a look at the first patch which is not that
> heavy, however it provides zero documentation, close to zero comments,
> but adds more than 500 lines of code. I find that a bit hard to give
> an opinion on, having commit messages associated to each patch would
> be also nice. This way, reviewers can figure what's going out in this
> mess and provide feedback. Making things incremental is welcome as
> well, for example in the first patch I have a hard way finding out why
> timestamps are touched to begin with.
My mistake here, only the first patch adds 8,200 lines of code. This
makes the lack of comments and docs even worse.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-11-03 12:39:00 | Re: dropping partitioned tables without CASCADE |
| Previous Message | Michael Paquier | 2017-11-03 12:30:53 | Re: Is it time to kill support for very old servers? |