Re: incorrect error message, while dropping PROCEDURE

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incorrect error message, while dropping PROCEDURE
Date: 2017-12-14 22:02:00
Message-ID: CAB7nPqTANHcv4+zu1FGDvPJtNYY6oWD8itFzw5JtALEN-9v=TQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 15, 2017 at 12:18 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 12/13/17 23:31, Rushabh Lathia wrote:
>> PFA patch, where introduced new AclObjectKind (ACL_KIND_PROCEDURE),
>> msg for the new AclObjectKind, and passed it through at
>> appropriate places.
>
> Yeah, that's a way to do it, but having both ACL_KIND_PROC and
> ACL_KIND_PROCEDURE is clearly confusing. The above-mentioned patch
> cleans that up more thoroughly, I think.

+1. I looked at the patch of Peter, as well as this one, and I prefer
Peter's approach of reducing duplications in concepts.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-12-14 22:21:00 Re: [HACKERS] Surjective functional indexes
Previous Message Andres Freund 2017-12-14 22:00:17 Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple