Re: Object files generated by ecpg test suite not ignored on Windows

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Object files generated by ecpg test suite not ignored on Windows
Date: 2015-03-09 23:17:28
Message-ID: CAB7nPqT9g0Q9bM175t+FY=_u8Hmv_N4dG922kuFeQ3QrE43b3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 10, 2015 at 2:50 AM, Michael Meskes <meskes(at)postgresql(dot)org> wrote:
> On 09.03.2015 16:58, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> The MSVC build creates project directories which contain all the .obj
>>> files etc. The file locations for intermediate artefacts are quite
>>> different from the way a Unix build works. There is an ignore rule for
>>> these directories, which covers the .obj files there. But ecpg files are
>>> generated like in Unix builds.
>>
>> Ah. That's lots more plausible than "no one's ever done any development
>> on Windows". I can believe that not so many people have run the ecpg
>> tests there.
>
> Completely agreed.
>
>>> Since we have a global ignore rule for .o
>>> files it makes plenty of sense to have one for .obj files also.
>>> Certainly better than have one rule for each ecpg test case.
>>
>> Agreed. So we should revert the previous patch ...
>
> Done.

Thanks for the fix. I did it as a global rule first, until noticing
that each regression item was listed in their own separate
.gitignore..
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-03-09 23:17:46 Re: Rethinking the parameter access hooks for plpgsql's benefit
Previous Message Peter Geoghegan 2015-03-09 23:06:11 Re: Documentation of bt_page_items()'s ctid field