Re: The real reason why TAP testing isn't ready for prime time

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The real reason why TAP testing isn't ready for prime time
Date: 2015-06-20 22:06:55
Message-ID: CAB7nPqT7ztxTDWOh-_+uQr8CK9iRkvF0RGWmx_GO_N3QY7cBwQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 20, 2015 at 6:53 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Sat, Jun 20, 2015 at 12:44 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> On 2015-06-19 11:16:18 -0400, Robert Haas wrote:
>>>> On Fri, Jun 19, 2015 at 11:07 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>>> I wonder whether it's such a good idea for the postmaster to give
>>>>> up waiting before all children are gone (postmaster.c:1722 in HEAD).
>>
>>>> I doubt it.
>>
>>> Seconded. It's pretty bad to possibly not be able to start again after
>>> stopping it. I don't see the benefit in not waiting - sure, the
>>> poastmaster exits faster, but postgres hasn't shut down at that point...
>>
>> Yeah. I'll see about fixing this. Hard to be sure if it will fix
>> hamster's issue though.
>
> I have re-enabled the TAP tests in hamster. What happens in the next
> couple of days will be interesting to see.he perl

And, we get a failure:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamster&dt=2015-06-20%2017%3A59%3A01
I am not sure why buildfarm runs makes it more easily reproducible,
one of the reasons may be the perl scripts run underground.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-06-20 22:15:44 Re: pg_stat_*_columns?
Previous Message Robert Haas 2015-06-20 21:56:13 Re: Is Postgres database server works fine if there is a change in system time?