Re: Incorrect processing of CREATE TRANSFORM with DDL deparding

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Incorrect processing of CREATE TRANSFORM with DDL deparding
Date: 2015-06-05 01:53:34
Message-ID: CAB7nPqT71m-VGHk1qdV7LMAgxBVM+5xHfu-nA_RBBi6BMJbm7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Jun 5, 2015 at 6:24 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> Michael Paquier wrote:
>
> > And I actually bumped into a bug with this fake test case:
> > DROP TRANSFORM FOR int LANGUAGE SQL;
> > + ERROR: requested object address for unsupported object class 32: text
> > result "unrecognized object 3576 16551 0"
> > What happens is that the handling for transforms in getObjectIdentityParts
> > is missing. This is fixed as well in the attached.
>
> Oh, interesting. We need one or two extra lines in the
> object_address.sql test as well, I guess.

Ah, so that's where it is... Attached is an updated patch with this
stuff. I noticed a couple of code paths where OCLASS_TRANSFORM was
missing as well.
--
Michael

Attachment Content-Type Size
20150605_transform_ddl_deparse_v4.patch text/x-patch 17.3 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2015-06-05 06:01:32 Re: BUG #13368: standby cluster immediately promotes after pg_basebackup from previously promoted master
Previous Message Josh Kupershmidt 2015-06-05 01:28:56 Re: reproducible 9.5: ERROR: requested object address for unsupported object class 32: ...