| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tomonari Katsumata <t(dot)katsumata1122(at)gmail(dot)com>, Tomonari Katsumata <katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should we remove "not fast" promotion at all? |
| Date: | 2013-08-06 03:56:48 |
| Message-ID: | CAB7nPqT6wtNO-UOnUTWU0g93E3h6obJ-LFVEJ5yrdFgxJx3wgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 6, 2013 at 12:41 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> -
>> + unlink(PROMOTE_SIGNAL_FILE);
>> Wouldn't it make sense to keep the call to stat() to check the file
>> status before unlinking it?
>
> Why do we need to check the existence of the file before removing it
> here?
Forget what I said, I had in mind that it might have been better to
put in silence errors of unlink here. This is not mandatory.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-08-06 04:07:22 | Re: Should we remove "not fast" promotion at all? |
| Previous Message | Andres Freund | 2013-08-06 03:52:47 | Re: Should we remove "not fast" promotion at all? |