Re: pgsql: Merge the various forms of transaction commit & abort records.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Merge the various forms of transaction commit & abort records.
Date: 2015-03-23 04:04:09
Message-ID: CAB7nPqT6BO1cCn+sAyDByBxA4EKZNAiPi2mFJ=ANeZmnmewRyg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Mar 16, 2015 at 1:38 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Merge the various forms of transaction commit & abort records.

Coverity is complaining about the following block of code:
+ xact_info = XLogRecGetInfo(record) & XLOG_XACT_COMMIT;
+
+ if (xact_info != XLOG_XACT_COMMIT &&
+ xact_info != XLOG_XACT_COMMIT_PREPARED)
return false;

Instead of XLOG_XACT_COMMIT, shouldn't this function use XLOG_XACT_OPMASK?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-03-23 14:29:27 pgsql: Remove ill-advised pre-check for DSM segment exhaustion.
Previous Message Bruce Momjian 2015-03-23 02:57:32 pgsql: to_char: revert cc0d90b73b2e6dd2f301d46818a7265742c41a14