| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Ignore src/tools/msvc/config.pl in code tree for MSVC compilation |
| Date: | 2014-05-12 06:08:06 |
| Message-ID: | CAB7nPqT69ftezbJUAYw91KVKby6u9AKrf9AgVv0fjVa1Mc_tOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
MSVC build uses two configuration perl files when running:
config_default.pl and config.pl. The former is mandatory and is
present in the code tree, while the latter can be used to override
settings with some custom parameters. As far as I understand from the
docs, config.pl should be used only in a custom environment and should
never be committed. Hence, why not adding a .gitignore in
src/tools/msvc and ignoring this file? This will prevent unfortunate
commits that could include this file and impact the devs working on
Windows. The patch attached does that. I think that it should be
back-patched for consistency across branches..
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Ignore-config.pl-in-src-tools-msvc.patch | text/plain | 678 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-05-12 06:25:01 | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |
| Previous Message | Amit Kapila | 2014-05-12 05:57:33 | Re: postgresql.auto.conf read from wrong directory |