Re: pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX
Date: 2016-12-05 09:09:05
Message-ID: CAB7nPqT5HaT0nsWqCFfnvQQWW6XXdcyX61xnsTz9dVP2RkEEPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 5, 2016 at 5:11 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> I'm afraid if we just start using EVP_CIPHER_CTX_new(), we'll leak the
> context on any error. We had exactly the same problem with EVP_MD_CTX_init
> being removed, in the patch that added OpenSSL 1.1.0 support. We'll have to
> use a resource owner to track it, just like we did with EVP_MD_CTX in commit
> 593d4e47. Want to do that, or should I?

I'll send a patch within 24 hours.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-12-05 09:49:53 Re: UNDO and in-place update
Previous Message Amit Kapila 2016-12-05 08:11:44 Re: commitfest 2016-11 status summary