| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog and replication slots |
| Date: | 2014-10-01 12:54:56 |
| Message-ID: | CAB7nPqT3madTjmOSFRMxoPKrrBPLZaFVoBybeP75oLwL2tjWog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks!
On Wed, Oct 1, 2014 at 8:38 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> 0001) Old WIP patch for pg_recvlogical tests. Useful for easier
> development.
>
From where is this patch? Is it some rest from the time when pg_recvlogical
was developed?
> 0002) Copy editing that should be in 9.4
>
Definitely makes sense for a backpatch.
> 0003) Rebased patches of yours
>
0004) My changes to 0003 besides the rebase. This'll be squashed, but I
> thought it might be interesting for you.
>
(thanks for caring)
- /* Drop a replication slot */
+ /* Drop a replication slot. */
I don't recall that comments on a single line have a dot even if this
single line is a complete sentence.
-static void StreamLog();
+static void StreamLogicalLog();
Not related at all to those patches, but for correctness it is better to
add a declaration "(void)".
Except those small things the changes look good to me.
Regards,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-10-01 12:59:26 | Re: pg_receivexlog and replication slots |
| Previous Message | Heikki Linnakangas | 2014-10-01 12:43:58 | Re: "Value locking" Wiki page |