Re: New pg_lsn type doesn't have hash/btree opclasses

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>
Subject: Re: New pg_lsn type doesn't have hash/btree opclasses
Date: 2014-05-09 13:14:25
Message-ID: CAB7nPqT-TuPOBWUgFmkTemSY0fDgtvK4s+zmp-h6ee9Z9e+FKg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 9, 2014 at 10:01 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> +DATA(insert OID = 3260 ( 403 pglsn_ops PGNSP PGUID ));
> +DATA(insert OID = 3261 ( 405 pglsn_ops PGNSP PGUID ));
>
> The patch looks good to me except the name of index operator class.
> I think that "pg_lsn_ops" is better than "pglsn_ops" because it's for "pg_lsn"
> data type.
Well, yes... Btw, before doing anything with this patch, I think that
the version of Fabrizio could be used as a base, but the regression
tests should be reshuffled a bit...
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-05-09 13:18:18 Re: New pg_lsn type doesn't have hash/btree opclasses
Previous Message Andres Freund 2014-05-09 13:11:36 Re: Cache lookup error when using jsonb, json_build_object and a WITH clause