Re: Fix broken Install.bat when target directory contains a space

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix broken Install.bat when target directory contains a space
Date: 2015-07-06 21:30:11
Message-ID: CAB7nPqT-F+nXxYJYtgR5xjkHqVg-cx6no7QoHyDxi1je8NizOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 7, 2015 at 4:19 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 07/06/2015 04:38 AM, Michael Paquier wrote:
>>
>> On Sat, Jul 4, 2015 at 3:57 AM, Heikki Linnakangas wrote:
>>>
>>> Hmm. Why is install.bat not like build.bat, i.e. just a thin wrapper that
>>> just calls install.pl, passing all arguments?
>>
>>
>> I guess we just haven't noticed it. And indeed it makes everything
>> more simple, and fixes as well the error reported when install path
>> contains a space.
>
>
> Ok, committed that way.

Shoudn't this patch be backpatched? In the backbranches install.bat
does not work correctly with paths containing spaces.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-07-06 21:34:20 Re: raw output from copy
Previous Message Stephen Frost 2015-07-06 21:26:38 Re: Redundant error messages in policy.c