| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org> |
| Subject: | Code inconsistency in convert.c for guid -> string conversion |
| Date: | 2014-03-03 02:38:36 |
| Message-ID: | CAB7nPqT=nDYF4_D6+X00iMbYhDYCOVQqpgfE80i_Dni3zZQnJw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-odbc |
Hi all,
While working on the code of odbc, I noticed an inconsistency in
convert.c, found by compiling the code with -Werror.
convert.c:4466: error: format '%08lX' expects type 'long unsigned
int', but argument 4 has type 'DWORD'
By looking closer at the code, the behavior in the code for guid ->
string conversion is inconsistent with char2guid using an sscan for
the similar reverse operation. I am attaching a patch fixing that.
On another note, I found as well the following warning:
dlg_specific.c:1491: error: the address of 'conn_settings' will always
evaluate as 'true'
All of this was reproduced using 09.03.0200.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20140303_convert_warning.patch | text/plain | 713 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-03-03 02:41:03 | Re: Code inconsistency in convert.c for guid -> string conversion |
| Previous Message | Inoue, Hiroshi | 2014-03-03 00:23:05 | Re: 09.03.0200 test failures |