| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2015-02-06 15:21:18 |
| Message-ID: | CAB7nPqSy+KK4mL6Mk47wUoVn=vsvQKvR53RJtnwmbjCXyn3_bA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 6, 2015 at 6:35 PM, Syed, Rahila wrote:
> The compression patch can use the latest interface MemoryContextAllocExtended to proceed without compression when sufficient memory is not available for
> scratch buffer.
> The attached patch introduces OutOfMem flag which is set on when MemoryContextAllocExtended returns NULL .
TBH, I don't think that brings much as this allocation is done once
and process would surely fail before reaching the first code path
doing a WAL record insertion. In any case, OutOfMem is useless, you
could simply check if compression_scratch is NULL when assembling a
record.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-02-06 16:09:32 | Re: ExplainModifyTarget doesn't work as expected |
| Previous Message | Tom Lane | 2015-02-06 15:10:31 | Re: RangeType internal use |