Re: pgsql: Allow pg_create_physical_replication_slot() to reserve WAL.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow pg_create_physical_replication_slot() to reserve WAL.
Date: 2015-08-14 06:32:17
Message-ID: CAB7nPqSwONSfu2Pk_p7kticomS4_4juG8UwAmATqzita7bVsxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Aug 11, 2015 at 7:47 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Allow pg_create_physical_replication_slot() to reserve WAL.
>
> When creating a physical slot it's often useful to immediately reserve
> the current WAL position instead of only doing after the first feedback
> message arrives. That e.g. allows slots to guarantee that all the WAL
> for a base backup will be available afterwards.
>
> Logical slots already have to reserve WAL during creation, so generalize
> that logic into being usable for both physical and logical slots.

Why hasn't this addition been spread as well in the replication
protocol? It seems to me that most of the refactoring work has been
done with ReplicationSlotReserveWal.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-08-14 06:50:36 Re: pgsql: Allow pg_create_physical_replication_slot() to reserve WAL.
Previous Message Peter Eisentraut 2015-08-14 04:02:15 pgsql: PL/Python: Make tests pass with Python 3.5