| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | "Karl O(dot) Pinc" <kop(at)meme(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2017-01-19 07:59:10 |
| Message-ID: | CAB7nPqSwN8QVfWTsyD=r_6ZtwZWOvhJQ0Kk4n6NozhS8NjiV9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 19, 2017 at 7:27 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> I thought this part was odd -- I mean, why is SysLogger_Start() being
> called if the collector is not enabled? Turns out we do it and return
> early if not enabled. But not in all cases -- there is one callsite in
> postmaster.c that avoids the call if the collector is disabled. That
> needs to be changed if we want this to work reliably.
Indeed. And actually it is fine to remove the call to FreeFile() in
the error code path of pg_current_logfile().
> I don't think the "abstract names" stuff is an improvement (just look at
> the quoting mess in ConfigureNamesString). I think we should do without
> that; at least as part of this patch. If you think there's code that
> can get better because of the idea, let's see it.
Agreed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2017-01-19 08:39:16 | Re: Logical replication existing data copy |
| Previous Message | Michael Paquier | 2017-01-19 07:56:45 | Re: pg_hba_file_settings view patch |