Re: [HACKERS] Timeline ID in backup_label file

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [HACKERS] Timeline ID in backup_label file
Date: 2018-01-06 00:56:03
Message-ID: CAB7nPqSvtxiGg3jq=VnNE6-tS2=bDn1RBrZh+PccZ8D3Dqvs3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 6, 2018 at 9:54 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Jan 5, 2018 at 11:13 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On 27 November 2017 at 14:06, David Steele <david(at)pgmasters(dot)net> wrote:
>>
>>> I have tested and get an error as expected when I munge the backup_label
>>> file:
>>>
>>> FATAL: invalid data in file "backup_label"
>>> DETAIL: Timeline ID parsed is 2, but expected 1
>>>
>>> Everything else looks good so I will mark it ready for committer.
>>
>> Sounds good.
>
> Thanks for the feedback.

Previous patch was incorrect, this was the same v2 as upthread.
Attached is the correct v3.
--
Michael

Attachment Content-Type Size
backup_label_tli_v3.patch application/octet-stream 4.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryan Murphy 2018-01-06 00:58:09 Re: January CommitFest is underway!
Previous Message Michael Paquier 2018-01-06 00:54:35 Re: [HACKERS] Timeline ID in backup_label file