Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM
Date: 2017-11-28 02:22:39
Message-ID: CAB7nPqSvJug6XLzHJ898bZSu5DCgYgcWd0iEsdUU3BMXgvwXwg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 14, 2017 at 4:44 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Oct 30, 2017 at 9:49 AM, Nikolay Shaplov <dhyan(at)nataraj(dot)su> wrote:
>> В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал:
>>
>> Yet another git rebase. This patch can be applied to master branch again.
>>
>> For this patch no review needed now, as I will offer part of it (one that
>> refuses to set toast reloptions when there is no TOAST table) as a separate
>> patch.
>
> This patch needs a rebase, there are conflicts with HEAD.

Bumping the patch to next CF as no updates have happened for the last two weeks.

> There is still no API equivalent for add_int_reloption(),
> add_real_reloption(), which is a problem as extension should be
> allowed to still use that. Except if I am missing something you could
> just have a compatibility API as for example optionCatalogAddItem()
> and add_reloption() share really a lot.

This worries me.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-11-28 02:23:38 Re: [HACKERS] [PATCH] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM
Previous Message Michael Paquier 2017-11-28 02:20:24 Re: [HACKERS] GnuTLS support