| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | TAP tests of pg_rewind not stopping servers used for the tests |
| Date: | 2015-04-15 12:07:43 |
| Message-ID: | CAB7nPqSsOs3bcJWPVg7fx1_=8=KdDD5Am4d+HE1=VPVZW9YZfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
In the refactoring of pg_rewind tests committed as 53ba107, it happens
that some of the servers used for the tests are not stopped at the end
of the test. The issue is that RewindTest.pm uses END to stop the
servers, but now that the local and remote tests are grouped half of
the servers are not stopped.
The reason why I did not notice that before is because as pg_rewind
uses local Unix socket to work on the nodes, the tests are not
failing.
Sorry about that, that's my fault. And attached is a patch fixing the
issue: it replaces END by a cleanup function called at the end of each
local/remote test to be sure that the servers are shut down.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150415_rewind_stop_servers.patch | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-04-15 12:20:27 | Re: FPW compression leaks information |
| Previous Message | Robert Haas | 2015-04-15 12:04:46 | Re: Turning off HOT/Cleanup sometimes |