| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Date: | 2017-05-25 02:41:19 |
| Message-ID: | CAB7nPqSrqKszjtnRc3YvKh7Pc1HJhtpaKW4gmeFM1QPcD2tSbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 25, 2017 at 11:34 AM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> From: pgsql-hackers-owner(at)postgresql(dot)org
>> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Noah Misch
>> Ten feels low to me. The value should be be low enough so users don't give
>> up and assume a permanent hang, but there's little advantage to making it
>> lower.
>> I'd set it such that we give up in 1-5s on a modern Windows machine, which
>> I expect implies a retry count of one hundred or more.
>
> Then, maybe we can measure the time in each iteration and give up after a particular seconds.
Indeed, pgrename() does so with a 100ms sleep time between each
iteration. Perhaps we could do that and limit to 50 iterations?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-05-25 03:11:28 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Previous Message | Tsunakawa, Takayuki | 2017-05-25 02:34:21 | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |