From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: option -T in pg_basebackup doesn't work on windows |
Date: | 2014-08-18 01:38:39 |
Message-ID: | CAB7nPqSpdQdB21RujxEjDKHiyNoMM1T6Tb_TysRmEVbNexXg9w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Aug 18, 2014 at 9:37 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> It's not ready for committer if the current patch does not apply.
FWIW, the latest version sent by Amit here applies correctly:
http://www.postgresql.org/message-id/CAA4eK1+cC9RB1S9Q4+nSOkfas1YufVFGFxUHxY_6wLBQ1ReroQ@mail.gmail.com
I haven't tested it myself though.
However, independently on this patch and as pointed by MauMau, the
code that has been committed in fb05f3c is incorrect in the way it
defines the tablespace path, this:
psprintf("%s/pg_tblspc/%d", basedir, oid);
should be this:
psprintf("%s/pg_tblspc/%u", basedir, oid);
I am separating this fix (that should be backpatched to REL9_4_STABLE
as well), in the patch attached if this helps.
Regards,
--
Michael
Attachment | Content-Type | Size |
---|---|---|
20140818_basebackup_tbspace_fix.patch | text/x-patch | 515 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2014-08-18 01:50:01 | Re: Why not ISO 8601 format for date values rendered into JSON? |
Previous Message | Tom Lane | 2014-08-18 00:42:11 | Why not ISO 8601 format for date values rendered into JSON? |