| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Ryan Murphy <ryanfmurphy(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: initdb: "'" for QUOTE_PATH (non-windows) |
| Date: | 2016-08-18 00:14:44 |
| Message-ID: | CAB7nPqSnfQDt-NfiWeF1BO9Sjy4+PM56=TiPqnEwYqv8J5xPbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 18, 2016 at 12:21 AM, Ryan Murphy <ryanfmurphy(at)gmail(dot)com> wrote:
> I have created a better patch (attached) that correctly escapes the shell
> arguments using PQExpBufferStr and the appendShellString function, as per
> Michael and Andres' suggestions.
>
> Further suggestions welcome of course.
As far as I know, it is perfectly possible to have LF/CR in a path
name (that's bad practice btw...), and your patch would make initdb
fail in such cases. Do we want to authorize that? If we bypass the
error checks in appendShellString with an extra option, and have
initdb use that, the generated command would be actually correct.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-08-18 00:15:29 | Re: CLUSTER, reform_and_rewrite_tuple(), and parallelism |
| Previous Message | Andres Freund | 2016-08-18 00:06:36 | pgsql: Fix deletion of speculatively inserted TOAST on conflict |