| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw IMPORT SCHEMA and partitioned tables |
| Date: | 2017-03-31 04:46:28 |
| Message-ID: | CAB7nPqSj1xWbkOYt+Cob3S_xYYxam1rN0_bvRVnb0HHMV5iZeg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 31, 2017 at 1:37 PM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> + <para>
> + For partitioned tables, partitions are automatically excluded from the
> + schema data imported. Only the definition of partitioned tables is
> included
> + to give access to the full data set of all partitions present remotely.
> + </para>
> +
>
> Only the definitions of "root" partitioned tables, because when using
> multi-level partitioning, there would be partitioned tables that won't be
> included (because, relispartition=true).
>
> If you agree, then this code comment too could use the same terminology:
>
> + * Ignore table data for partitions and only include the parent
> + * definitions to allow access to the complete remote data set
> + * locally in the schema imported.
> + *
That makes sense. Updated this way as I have my hands on it now.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgfdw-partitions-v2.patch | application/octet-stream | 8.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-03-31 04:49:59 | Re: Logical decoding on standby |
| Previous Message | Kuntal Ghosh | 2017-03-31 04:42:11 | Re: strange parallel query behavior after OOM crashes |