Re: logical replication and PANIC during shutdown checkpoint in publisher

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logical replication and PANIC during shutdown checkpoint in publisher
Date: 2017-05-28 04:30:47
Message-ID: CAB7nPqSd9sBrs8VSOttMUcE-jMTyQ6XW7U_Yk-pjyfX-ZEWrtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 26, 2017 at 4:47 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 5/26/17 14:16, Michael Paquier wrote:
>> So, now that the last round of minor releases has happened and that
>> some dust has settled on this patch, shouldn't there be a backpatch?
>> If yes, do you need patches for all branches? This problems goes down
>> to 9.2 anyway as BASE_BACKUP can generate end-of-backup records.
>
> Yes, this could be backpatched now. It looks like it will need a bit of
> fiddling to get it into all the backbranches. If you want to give it a
> closer look, go ahead please.

Attached are patches for 9.2~9.6. There are a couple of conflicts
across each version. Particularly in 9.2, I have made the choice to
not rename walsender_ready_to_stop to got_SIGINT as this is used as
well in basebackup.c to make clearer the code. In 9.3~ the use of this
flag is located only within walsender.c.
--
Michael

Attachment Content-Type Size
walsender-shutdown-96.patch application/octet-stream 13.1 KB
walsender-shutdown-95.patch application/octet-stream 13.1 KB
walsender-shutdown-93.patch application/octet-stream 11.7 KB
walsender-shutdown-94.patch application/octet-stream 13.2 KB
walsender-shutdown-92.patch application/octet-stream 12.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-05-28 05:15:43 Re: [JDBC] Channel binding support for SCRAM-SHA-256
Previous Message Jeff Janes 2017-05-28 02:34:27 execGrouping.c limit on work_mem