| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Allow pg_create_physical_replication_slot() to reserve WAL. |
| Date: | 2015-08-14 07:03:51 |
| Message-ID: | CAB7nPqSco+RFw9C-VgbCpyurQB3OocS-fuTOa_gFnUy1EE-pyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Aug 14, 2015 at 3:50 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-08-14 15:32:17 +0900, Michael Paquier wrote:
>> Why hasn't this addition been spread as well in the replication
>> protocol? It seems to me that most of the refactoring work has been
>> done with ReplicationSlotReserveWal.
>
> Feel free to send a patch.
I don't mind giving it a try if time allows... CREATE_REPLICATION_SLOT
IDENT K_PHYSICAL slot_options? With slot_options: (reserve = on/off)?
And, actually, here is an unrelated patch, the docs are referring to
confirmed_flush instead of confirmed_flush_lsn ;)
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150814_confirmed_lsn_docfix.patch | text/x-diff | 488 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-08-14 07:07:24 | Re: pgsql: Allow pg_create_physical_replication_slot() to reserve WAL. |
| Previous Message | Andres Freund | 2015-08-14 06:50:36 | Re: pgsql: Allow pg_create_physical_replication_slot() to reserve WAL. |