Re: [BUGS] BUG #8542: Materialized View with another column_name does not work?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: "t(dot)katsumata1122(at)gmail(dot)com" <t(dot)katsumata1122(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #8542: Materialized View with another column_name does not work?
Date: 2013-11-01 01:58:06
Message-ID: CAB7nPqSaCFY8HqrLhUJgLmGJxfzDuMtP+Kx0SUUraZp5Mrkw8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Oct 31, 2013 at 10:22 PM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> "t(dot)katsumata1122(at)gmail(dot)com" <t(dot)katsumata1122(at)gmail(dot)com> wrote:
> If there are no objections I'll apply this within a few days.
I am not sure that adding a boolean flag introducing a concept related
to matview inside checkRuleResultList is the best approach to solve
that. checkRuleResultList is something related only to rules, and has
nothing related to matviews in it yet. I have been pondering myself
about this issue, and wouldn't it be better to directly enforce
targetList in checkRuleResultList call at an upper level with the
column name list given by users if there is any instead of the list of
columns of the SELECT query?

After looking closely at the code this looks to be a better approach
from a general viewpoint. I didn't got the time to write a patch but
this is the conclusion I reached after some analysis at least...
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Ashutosh Bapat 2013-11-01 04:48:11 Re: [BUGS] BUG #8542: Materialized View with another column_name does not work?
Previous Message Kevin Grittner 2013-10-31 22:22:57 Re: [BUGS] BUG #8542: Materialized View with another column_name does not work?

Browse pgsql-hackers by date

  From Date Subject
Next Message Dann Corbit 2013-11-01 02:46:33 Re: postgresql-9.3.1-1-windows-x64.exe does not install correctly for me
Previous Message Adrian Klaver 2013-11-01 00:03:05 Re: postgresql-9.3.1-1-windows-x64.exe does not install correctly for me