From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Kevin Grittner <kgrittn(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Improve tab completion for REFRESH MATERIALIZED VIEW |
Date: | 2016-01-27 02:54:02 |
Message-ID: | CAB7nPqSa69XkoeszZYDDx1SFyeNM=ONzTgdgSoX+yPLNiCckxQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 27, 2016 at 11:41 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> But ISTM that CREATE MATERIALIZED VIEW <tab> doesn't list
> existing matviews yet. What's worse it lists existing *views*.
Yep.
> This happens because words_after_create mechanism doesn't support
> the case where the keyword has more than one words like "MATERIALIZED VIEW".
Having worked on that, I am not convinced this is worth the complication.
> Probably we should improve that mechanism so that even multiple words can be
> handled. Or we should just add something like the following.
>
> /* Complete CREATE MATERIALIZED VIEW with <name> */
> + else if (Matches3("CREATE", "MATERIALIZED", "VIEW"))
> + COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_matviews, NULL);
Indeed, we do the same for tables and views as well. That would be fine.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2016-01-27 02:56:38 | Re: brin_summarize_new_values error checking |
Previous Message | Fujii Masao | 2016-01-27 02:41:58 | Re: Improve tab completion for REFRESH MATERIALIZED VIEW |