Re: Regression tests for deprecated functions

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Regression tests for deprecated functions
Date: 2014-06-13 00:51:52
Message-ID: CAB7nPqS_tv+gya-YXFJoBEdwDgA+FBGhrrZQyzxZfeuu0t1mCQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

On Thu, Jun 12, 2014 at 11:13 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> I spotted one more issue in the regression test for deprecated functions:
>
> The comment in it correctly states, SQLColAttributes has been replaced with
> SQLColAttribute. But the regression test then calls SQLColAttribute, i.e.
> the new functions, not the deprecated one. I haven't looked what difference
> it makes in practice.
The field identifiers have been changed from SQL_COLUMN_* to SQL_DESC_*:
http://msdn.microsoft.com/en-us/library/ms710910%28v=vs.85%29.aspx
Hence I think that the patch attached is enough, even if we do not
test all the field identifiers..

> (We don't have any other regression tests for the new SQLColAttribute, which
> would be nice to have anyway)
True.
--
Michael

Attachment Content-Type Size
20140613_pgodbc_deprecated_fix.patch text/plain 582 bytes

In response to

Browse pgsql-odbc by date

  From Date Subject
Next Message Hiroshi Inoue 2014-06-13 03:59:07 Re: XA registry entries are missing from 64-bit install
Previous Message Michael Paquier 2014-06-13 00:39:42 Re: Running regression tests on Windows