Re: dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.
Date: 2016-12-18 21:57:00
Message-ID: CAB7nPqSULJYggOtdq=awma7rBkQdUd6RNFCbUFJLXy=OAGGNCg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 19, 2016 at 6:48 AM, Joe Conway <mail(at)joeconway(dot)com> wrote:
> Maybe if "CREATE FOREIGN DATA WRAPPER" had a way to specify that the FDW
> supports a libpq connection it would make sense to allows other FDWs
> with this attribute, but since there is none the current state strikes
> me as a bad idea.
>
> Thoughts?

libpq is proper to the implementation of the FDW, not the wrapper on
top of it, so using in the CREATE FDW command a way to do the
decision-making that does not look right to me. Filtering things at
connection attempt is a better solution.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2016-12-18 22:47:28 Re: dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.
Previous Message Joe Conway 2016-12-18 21:48:51 Re: dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.