Re: Rename RECOVERYXLOG to RECOVERYWAL?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Rename RECOVERYXLOG to RECOVERYWAL?
Date: 2017-09-01 23:53:31
Message-ID: CAB7nPqSSd79d_QVchVsVt0yLLh2pV=g+RoQVk362X6fnF0p96g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 2, 2017 at 3:06 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I don't think this really buys us anything. If we'd applied it to v10
> maybe, but what do we get out of whacking it around now?
>
> "Consistency", I hear you cry! Fair point. But we never had a goal
> of eliminating all internal references to "xlog", just the user-facing
> ones. And since RECOVERYXLOG is not documented, I think there's a
> good argument that it's not user-facing. You could argue that since
> it shows up in the file system it's implicitly user-facing, and maybe
> you're right; if some other committer really wants to make this
> change, I won't grouse much. But personally I'd favor leaving it
> alone to avoid having the behavior change a little bit in every new
> release.

I may be wrong, but I would suspect that some backup tools doing
FS-level backup are checking on the existence of this file and skip
it. From the point of view of operations, it does not matter much as
any existing RECOVERYXLOG is unlinked before being replaced by a new
one, but that would not be nice to add silently 16MB in each backup.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-09-02 00:11:59 Re: More replication race conditions
Previous Message Michael Paquier 2017-09-01 23:49:22 Re: Upcoming commit fest will begin soon