From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, "Wood, Dan" <hexpert(at)amazon(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
Subject: | Re: Old row version in hot chain become visible after a freeze |
Date: | 2017-09-07 01:23:46 |
Message-ID: | CAB7nPqSRbohi9L0EH4QMZMPYT_mZ3YQg0xf5QUxvdSmixd7-tQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Wed, Sep 6, 2017 at 7:40 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Otherwise, we risk marking the page as all-frozen, and it would be
> skipped by vacuum. If we never come around to HOT-pruning the page, a
> non-permanent xid (or a multixact? not sure that that can happen;
> probably not) would linger unnoticed and cause a DoS condition later
> ("cannot open file pg_clog/1234") when the tuple header is read.
Yes, you are definitely right here.
On Wed, Sep 6, 2017 at 10:27 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Another thing is that if you're going through heap_copy_data, the tuple
> is only checked for DEAD, not RECENTLY_DEAD. Maybe there is no bug here
> but I'm not sure yet.
Not sure to what you are referring here. Perhaps heap_prune_chain()?
It seems to me that it does the right thing.
> I attach the patch as I have it now -- mostly comment tweaks, but also
> the change to not mark page as all-frozen when we skip freezing a
> recently read tuple. I also renamed the test case, because I think it
> may be possible to reach the problem code without involving a multixact.
> Haven't tried too hard though.
+test: freeze-the-dead
This one has made me smile..
+++ b/src/test/isolation/expected/freeze-the-dead.spec
@@ -0,0 +1,101 @@
+Parsed test spec with 2 sessions
The test fails as expected/ files need to be named with .out, not .spec.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Frost | 2017-09-07 03:23:28 | Re: Old row version in hot chain become visible after a freeze |
Previous Message | Alvaro Herrera | 2017-09-06 22:12:17 | Re: Old row version in hot chain become visible after a freeze |