| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: contrib/bloom wal-check not run by default |
| Date: | 2017-04-11 05:49:48 |
| Message-ID: | CAB7nPqSFsKTxMy9z7hR-JqBNM8FLmnAS6SeceHee9PA8+=zwhQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 11, 2017 at 12:14 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Why $subject?
>
> Does it just need to be wired into the makefiles a bit better?
Looks like an oversight to me. I would suggest changing the Makefile like that:
diff --git a/contrib/bloom/Makefile b/contrib/bloom/Makefile
index 13bd397b70..834ab18bdc 100644
--- a/contrib/bloom/Makefile
+++ b/contrib/bloom/Makefile
@@ -20,5 +20,7 @@ include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
-wal-check: temp-install
+check: prove-check
+
+prove-check:
$(prove_check)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-04-11 06:17:57 | Re: Variable substitution in psql backtick expansion |
| Previous Message | Michael Paquier | 2017-04-11 05:25:08 | Re: Implementation of SASLprep for SCRAM-SHA-256 |