Re: Retrieving query results

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Igor Korot <ikorot01(at)gmail(dot)com>, pgsql-general <pgsql-general(at)postgresql(dot)org>
Subject: Re: Retrieving query results
Date: 2017-08-24 22:57:50
Message-ID: CAB7nPqSE5voeA5LTDZ6PLkA4jNWuYB7nJJTaXRJBREH2LJE2Fg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Thu, Aug 24, 2017 at 11:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I haven't tried it, but it sure looks like it would, if you don't hit
> OOM first. pqAddTuple() isn't doing anything to guard against integer
> overflow. The lack of reports implies that no one has ever tried to
> retrieve even 1G rows, let alone more ...

Yeah, looking at the code we would just need to check if ntups gets
negative (well, equal to INT_MIN) after being incremented.
--
Michael

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Igor Korot 2017-08-24 23:05:22 Re: Retrieving query results
Previous Message Peter Hunčár 2017-08-24 20:22:39 Re: Multixact members limit exceeded