From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Making tab-complete.c easier to maintain |
Date: | 2016-01-05 05:26:55 |
Message-ID: | CAB7nPqSBpA8RkyA9H7yqcKZt0L_W8iei0sT+HNqbAiWj+g9O8Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 5, 2016 at 10:13 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> So, here are the commands that still remain with TailMatches to cover
>> this case, per gram.y:
>> - CREATE TABLE
>> - CREATE INDEX
>> - CREATE VIEW
>> - GRANT
>> - CREATE TRIGGER
>> - CREATE SEQUENCE
>> New patches are attached.
>
> I've reviewed and committed the first of these patches. I found a few
> mistakes, mostly where you'd converted TailMatches to Matches without
> adding the leading words that the original author had left out of the
> pattern. But man, this is mind-numbingly tedious work :-(. I probably
> made a few more mistakes myself. Still, the code is enormously more
> readable now than when we started, and almost certainly more reliable.
Thanks. My best advice is to avoid doing such after 10PM, that's a
good way to finish with a headache. I did it.
> I'm too burned out to look at the second patch tonight, but hopefully
> will get to it tomorrow.
I see that you are on fire these days, still bodies need some rest.
This second one still applies cleanly, but it is far less urgent, the
other psql-tab patches do not depend on it.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-01-05 05:27:33 | Re: dynloader.h missing in prebuilt package for Windows? |
Previous Message | Michael Paquier | 2016-01-05 05:18:42 | Re: dynloader.h missing in prebuilt package for Windows? |