From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] JIT compiling expressions/deform + inlining prototype v2.0 |
Date: | 2017-11-30 01:01:54 |
Message-ID: | CAB7nPqSBD=rM-3fmpThsfrFZo-fW_OuWzNiJV8+HW-_jnGXNbg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 21, 2017 at 2:52 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2017-09-19 12:57:33 +0300, Konstantin Knizhnik wrote:
>>
>>
>> On 04.09.2017 23:52, Andres Freund wrote:
>> >
>> > Hi. That piece of code isn't particularly clear (and has a bug in the
>> > submitted version), I'm revising it.
>>
>> ...
>> > Yea, I've changed that already, although it's currently added earlier,
>> > because the alignment is needed before, to access the column correctly.
>> > I've also made number of efficiency improvements, primarily to access
>> > columns with an absolute offset if all preceding ones are fixed width
>> > not null columns - that is quite noticeable performancewise.
>> >
>> >
>> Should I wait for new version of your patch or continue review of this code?
>
> I'll update the posted version later this week, sorry for the delay.
I know that you are working on this actively per the set of patches
you have sent lately, but this thread has stalled, so I am marking it
as returned with feedback. There is now only one CF entry to track
this work: https://commitfest.postgresql.org/15/1285/. Depending on
the work you are doing you may want to spawn a CF entry for each
sub-item. Just an idea.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-11-30 01:11:09 | Re: Use of uninitialized variables in ExecFindPartition() for parent partition without leaves (HEAD only) |
Previous Message | Michael Paquier | 2017-11-30 00:59:09 | Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause |