| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel |
| Date: | 2015-07-01 12:24:08 |
| Message-ID: | CAB7nPqS89bRiP+az_kGR3tpPqwgP=0RZ58ZZBs0eTTBW-Aygmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 30, 2015 at 9:57 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-06-30 21:53:07 +0900, Michael Paquier wrote:
>> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
>> is doing a NULL-pointer check for something that has been dereferenced
>> on all the code paths leading to this check.
>> (Yes, that's not interesting for common humans, Coverity sees things
>> based on correctness).
>
> Can you, in the future, batch these together into one thread, perhaps
> with one message below an introductory one for each patch? Unless
> they'll get applied immediately it'll be hard to follow the different
> threads.
I'll try.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-07-01 12:31:52 | Re: pg_rewind failure by file deletion in source server |
| Previous Message | Michael Paquier | 2015-07-01 11:58:30 | Re: Expending the use of xlog_internal.h's macros |