From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Marc Mamin <M(dot)Mamin(at)intershop(dot)de> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: "pivot aggregation" with a patched intarray |
Date: | 2014-06-01 11:43:11 |
Message-ID: | CAB7nPqS2vYO_u8nsjca=DsArhO-KOZGRj4_Qvp5GZ0qDLZ4XfQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, May 31, 2014 at 12:31 AM, Marc Mamin <M(dot)Mamin(at)intershop(dot)de> wrote:
> I have patched intarray with 3 additional functions in order to count[distinct] event IDs
> into arrays, whereas the array position correspond to the integer values. (mimic column oriented storage)
I didn't look at the feature itself, but here are some comments about
the format of the patch:
- Be careful the newlines on the file you posted use ¥r¥n, which is
purely Windows stuff... This will generate unnecessary diffs with the
source code
- Here are some guidelines about the code convention:
http://www.postgresql.org/docs/devel/static/source.html
- And here are a couple of rules to respect when submitting a patch:
https://wiki.postgresql.org/wiki/Submitting_a_Patch
Following those rules will make patch review as well as the life of
reviewers easier.
Regards,
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Marc Mamin | 2014-06-01 13:48:56 | Re: "pivot aggregation" with a patched intarray |
Previous Message | Andres Freund | 2014-06-01 07:35:27 | Re: pg_sleep() doesn't work well with recovery conflict interrupts. |