| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Missing lookup in msvcr120 for pgwin32_putenv |
| Date: | 2016-04-22 03:16:22 |
| Message-ID: | CAB7nPqS1Mjg-zyxRoACSi9uqLg7jzm8W68zXG+_OWq+5f_gY9w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
While looking at e545281 I bumped into the following thing that has
visibly been forgotten since VS2013 support has been added:
--- a/src/port/win32env.c
+++ b/src/port/win32env.c
@@ -67,6 +67,9 @@ pgwin32_putenv(const char *envval)
"msvcr110", 0, NULL
}, /* Visual Studio 2012 */
{
+ "msvcr120", 0, NULL
+ }, /* Visual Studio 2013 */
+ {
NULL, 0, NULL
}
};
Attached is a patch. This should be backpatched to 9.3 where, if I
recall correctly, support for VS2013 has been added.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| vs-2013-putenv.patch | application/x-download | 348 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-04-22 03:37:54 | New 9.6 external sort guidance around temp_tablespaces and maintenance_work_mem |
| Previous Message | Michael Paquier | 2016-04-22 03:11:32 | Re: Dead code in win32.h |