| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: relkind check in DefineIndex |
| Date: | 2017-10-16 09:58:27 |
| Message-ID: | CAB7nPqS+tz8KsYFvMvhCAuopOsB1=Yh1V4hq2X5bwiCiOcJzoA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 16, 2017 at 2:56 PM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2017/10/14 4:32, Robert Haas wrote:
>> On Fri, Oct 13, 2017 at 12:38 PM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>> The relkind check in DefineIndex has grown into an ugly rats nest of
>>> 'if' statements. I propose to change it into a switch, as per the
>>> attached.
>>
>> wfm
>
> +1
+1. There is as well CreateTrigger(), analyze_rel() or
ATRewriteCatalogs() that do similar things but those are not using
multiple layers of checks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-10-16 10:55:53 | Re: Determine state of cluster (HA) |
| Previous Message | Ashutosh Bapat | 2017-10-16 09:44:05 | Re: [POC] hash partitioning |