From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: Unportable use of select for timeouts in PostgresNode.pm |
Date: | 2017-07-17 15:16:19 |
Message-ID: | CAB7nPqRySh87HYMPKh+oj65SH-69f6c=LGNEnO+F7OaQBJg3og@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 17, 2017 at 4:48 PM, Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
> This is a usage that is known not to work in Windows - IIRC we
> eliminated such calls from our C programs at the time of the Windows
> port - and it seems to me very likely to be the cause of the hang.
> Instead I think we should use the usleep() function from the standard
> (from 5.8) Perl module Time::HiRes, as recommended in the Perl docs for
> the sleep() function for situations where you need finer grained
> timeouts. I have verified that this works on jacana and friends.
Looking at my boxes (Arch, Mac, Windows), Time::Hires looks to be part
of the core set of packages, so there is visibly no real need to
incorporate a check in configure.in. So +1 for doing as you suggest.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-07-17 15:27:16 | Re: Something for the TODO list: deprecating abstime and friends |
Previous Message | Michael Paquier | 2017-07-17 15:00:02 | Re: AdvanceXLInsertBuffer vs. WAL segment compressibility |