| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Support for Secure Transport SSL library on macOS as OpenSSL alternative |
| Date: | 2017-08-21 00:46:43 |
| Message-ID: | CAB7nPqRxrt9J3afm_1nmo649+so37bqX3KjKjuaDpJe3CH76+A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 21, 2017 at 6:21 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 19 Aug 2017, at 23:13, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>>> I guess it should have a fallback definition, though I don't know what
>>> it should be.
>>
>> Or maybe the guc should only exist if SSL_LIBRARY is defined?
>
> I think the intended use case of the GUC should drive the decision on fallback.
> If the GUC isn’t supposed to be a way to figure out if the server was built
> with SSL support, then not existing in non-SSL backends is fine. If, however,
> we want to allow using the GUC to see if the server has SSL support, then there
> needs to be a “None” or similar value for that case.
Only GUCs related to debugging have their existence defined based on a
#define, so it seems to me that if Postgres is compiled without any
SSL support, this parameter should still be visible, but set to
"none".
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-08-21 01:18:35 | Re: POC: Sharing record typmods between backends |
| Previous Message | Joshua D. Drake | 2017-08-21 00:25:02 | Re: Updating line length guidelines |