Re: BUG #14162: No statistics for functions used as aggregates

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Daniel Migowski <dmigowski(at)ikoffice(dot)de>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14162: No statistics for functions used as aggregates
Date: 2016-05-31 04:56:38
Message-ID: CAB7nPqRwvFnEtUOH2XrWfghCk-PR4n8DP4zMJQ8duzQK2wc3DQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, May 30, 2016 at 4:56 PM, Daniel Migowski <dmigowski(at)ikoffice(dot)de> wrote:
> Yes, I am sure. To measure my function I had to recreate it with a different name, and create a plpgsql wrapper function with the original signature that calls it. Now I was able to get my results and the function showed up in the stats. The wrapper didn't!

(please do not top-post it breaks the logic of the thread).
Ah I see I got confused, nodeAgg.c does not track statistics of the
transition or final functions when an aggregate is invoked, and has
never done it. There is no call to pgstat_init_function_usage() when
FunctionCallInvoke() is called so you cannot track statistics
regarding that. Maybe that would be a interesting feature, but
controlled by a different GUC than track_functions.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Daniel Migowski 2016-05-31 05:47:58 Re: BUG #14162: No statistics for functions used as aggregates
Previous Message Peter Geoghegan 2016-05-30 21:00:39 Re: BUG #14134: segmentation fault with large table with gist index